Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021 Caching chapter #2443

Merged
merged 122 commits into from
Dec 14, 2021
Merged

2021 Caching chapter #2443

merged 122 commits into from
Dec 14, 2021

Conversation

Zizzamia
Copy link
Contributor

@Zizzamia Zizzamia commented Nov 6, 2021

#2161
Working in progress

Staged URL: https://20211129t162816-dot-webalmanac.uk.r.appspot.com/en/2021/caching (manually updated, not synced with this PR)

@Zizzamia Zizzamia mentioned this pull request Nov 6, 2021
6 tasks
@rviscomi rviscomi added the writing Related to wording and content label Nov 6, 2021
@rviscomi rviscomi added this to the 2021 Content Writing milestone Nov 6, 2021
@rviscomi
Copy link
Member

rviscomi commented Nov 8, 2021

Glad to see the draft coming together @Zizzamia. When are you aiming to have the chapter in a reviewable state?

Aside from that, when the chapter is reviewable, mark the PR "ready for review" and assign it to the reviewers: @jessnicolet @WilhelmWillie @roryhewitt @boosef. That'll hopefully be a clear signal to start giving feedback.

@rviscomi
Copy link
Member

⚠️ @Zizzamia following up on my last comment. In order to have this in a launchable state in two weeks, the draft should be done no later than Monday, November 15. That gives reviewers a week to provide feedback so that you can spend the week of Monday, November 22 resolving that feedback and putting on the final polish. That will have the chapter written and reviewed with two days to spare. Does that sound doable?

@rviscomi rviscomi added the ASAP This issue is blocking progress label Nov 16, 2021
src/content/en/2021/caching.md Outdated Show resolved Hide resolved
src/content/en/2021/caching.md Outdated Show resolved Hide resolved
@rviscomi
Copy link
Member

I'll add the corresponding screenshots at the end when all figures are in.

@Zizzamia Zizzamia force-pushed the zizzamia/caching-2021 branch from 241f71b to 46278e6 Compare November 20, 2021 22:51
@rviscomi
Copy link
Member

@Zizzamia all requested figures should be ready now

@github-actions
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 20%, saving 39.02 KB.

Filename Before After Improvement Visual comparison
src/static/images/2021/caching/cache-control-adoption.png 56.41 KB 42.23 KB -25.1% View diff
src/static/images/2021/caching/sw-adoption.png 56.89 KB 45.85 KB -19.4% View diff
src/static/images/2021/caching/top-cdns.png 81.96 KB 68.15 KB -16.9% View diff

1307 images did not require optimisation.

@rviscomi
Copy link
Member

@Zizzamia could you give us an estimate when you expect the final draft to be ready?

@Zizzamia Zizzamia force-pushed the zizzamia/caching-2021 branch from 9f8f19f to aa73e91 Compare November 27, 2021 22:01
@HTTPArchive HTTPArchive deleted a comment from jessnicolet Nov 27, 2021
@HTTPArchive HTTPArchive deleted a comment from jessnicolet Dec 5, 2021
@HTTPArchive HTTPArchive deleted a comment from jessnicolet Dec 5, 2021
@tunetheweb
Copy link
Member

@Zizzamia how's it looking? I've restaged the chapter to the staging link: https://20211129t162816-dot-webalmanac.uk.r.appspot.com/en/2021/caching

Eric is making great progress on the Media chapter in #2705 so it would be great to get both of these merged and released for this weekend.

@tunetheweb
Copy link
Member

tunetheweb commented Dec 11, 2021

Hi @Zizzamia / @jessnicolet we've just merged the other outstanding chapter (Media). It still needs a quick copy edit so not quick ready to release but pretty close.

How are you getting on and do you think you'll be done this weekend? It would be great to launch both outstanding chapters together.

@Zizzamia
Copy link
Contributor Author

Ciao @tunetheweb, after dinner I will merge all feedbacks and give a final read. And by the next two hours we should have complete this chapter. Will ping you back as we finished.

@Zizzamia
Copy link
Contributor Author

Zizzamia commented Dec 13, 2021

@tunetheweb we are ready to merge. The only thing left is probably a quick copy edit as well, but beside that we are good to go.

@tunetheweb tunetheweb merged commit 6530a61 into main Dec 14, 2021
@tunetheweb tunetheweb deleted the zizzamia/caching-2021 branch December 14, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP This issue is blocking progress writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants